微博上传图片时只在前端进行验证, 服务器端没有进行安全过滤。
1 F' P9 v4 p8 P. S0 o' q; S+ b+ ?# Q* T- r
3 x5 s, `" g% V" ~: x. {\api\StatusesApi.class.php# T) I8 I" n" G' [
: u9 o5 \7 m* t2 T, ifunction uploadpic(){) Z4 o, }* r7 ?" ~2 c' Y0 Q* i
if( $_FILES['pic'] ){
, w7 q! t0 m8 ~% v //执行上传操作; o( |) J6 L0 }3 r7 ~
$savePath = $this->_getSaveTempPath();
; c' U5 e) x: u! B& F5 l; G* ^( f $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
8 q ]& R' y9 {$ }2 i! p' h if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))
0 G/ ?4 f- m" q, m: s {
4 v+ m+ F, r6 O9 u" N* \ $result['boolen'] = 1;
/ A% E0 J1 @9 D) n* U( u/ w $result['type_data'] = 'temp/'.$filename;
6 {" b" C) W, e) S% K. K- H: e $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;
! w- @# R. z* |3 |7 { } else {- M3 a6 G# _- q& ?1 z* J8 a$ d
$result['boolen'] = 0;
1 A& i. p( i6 S: r8 j6 G8 R. |# @9 } $result['message'] = '上传失败';* G) A T x0 B8 G. o! Y, S4 e
}
2 f( e/ i& z- K& A1 _ }else{1 c- }, P' j! G# x) E7 ?2 _* s4 a
$result['boolen'] = 0; G3 o' N2 |# X1 T7 @! M5 c( }4 a1 `
$result['message'] = '上传失败';" j1 ]; U4 w/ W6 r
}
4 G1 s7 X9 q* D7 |+ ]+ Yreturn $result;& z. o) _- P6 k1 Z
}, A6 U5 t6 x3 }3 y
unloadpic()方法没有对文件类型进行验证
' s( l" s" R2 J- R7 u' ^ % N9 A" V3 t0 ]1 f: \' [
可以构建表单, 选择任意文件, 提交到
! v7 U. z* a5 e, I- v* {" k/index.php?app=w3g&mod=Index&act=doPost D2 S5 z& v7 J% r
0 t* K' K6 ?" O% x7 f在新提交的微博上可以找到上传的文件地址(去掉small_、middle_ 前缀)! _- G* @- P# c: H$ z7 P
! B x+ @7 ^# h/ s; ]& w4 _' i H: R
在登录thinksns官方微博后,. C! G" N3 Y' g1 y0 T+ K
构建以下表单:- X$ N) p* P/ o
, g! o& c. V+ R& I% W% r
<form action="http://t.thinksns.com/index.php?app=w3g&mod=Index&act=doPost" method="post" enctype="multipart/form-data" />2 e( b* B. H8 r m$ Q( Q. _
<textarea name="content">test</textarea>( d) l- ~8 k( Y% d' f7 d1 I
file: <input id="file" type="file" name="pic" />& R9 x; `5 h0 P0 Y7 D, o/ b) W: G' p
<input type="submit" value="Post" />
; d. u1 J4 ]* K. P. O5 j' K: A</form>. G, {3 A# p* V/ [% {+ K* D$ B
去掉缩略图的前缀(small_ )* f" i0 s0 {) M
修复方案:. w- V! n' o5 p* @" F5 \1 O
4 ^; D7 \2 J# W9 K6 d" V) G1 Y" [) D+ K/ M! V/ b4 [/ g8 c
\api\StatusesApi.class.php6 |) q; L% N) m- i- M& @
" R- E1 ^1 y8 V# x9 q+ b5 v
function uploadpic(){5 F; `& B; D G8 g+ N
/**' ^8 n' v: ^6 J) l/ y; S
* 20121018 @yelo" D* R/ C7 J3 p! c3 n! U8 O
* 增加上传类型验证
. [5 I, c( c; H6 Z- u" H7 `! e- e */
3 R* \ M) l- S$ P0 P1 y $pathinfo = pathinfo($_FILES['pic']['name']);( `# Y& a6 z& t6 k4 t* f& f8 u
$ext = $pathinfo['extension'];
( ]4 i1 |0 K0 F% R) J $allowExts = array('jpg', 'png', 'gif', 'jpeg');0 Z8 x7 Y6 f7 r5 k2 l6 r
! Q1 v1 S4 r# f: Y* _# i
$uploadCondition = $_FILES['pic'] && in_array(strtolower($ext),$allowExts,true);
# P; q8 K9 x, j; m" m
( q4 Z- u7 |/ L2 k if( $uploadCondition ){
" U/ P7 d" h9 z4 H //执行上传操作
# j: F1 w+ @; g& ^ $savePath = $this->_getSaveTempPath();
6 K% U$ I7 u8 q; i $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
" c" f" f; Z$ t3 r. s7 e: ?# ?' Z0 Z' p0 s if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))2 q1 {! T _, r8 v
{& N: @: o. e2 s+ w" w4 [$ R
$result['boolen'] = 1;
) h4 C$ }: a7 U) H2 j $result['type_data'] = 'temp/'.$filename;
4 v+ D) J- Q0 m# {5 Q' q $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;# I9 u& a; e9 f! b. N! N% W N
} else {& w D! S. Q; N; K, F2 s
$result['boolen'] = 0;7 o+ w6 z! p5 @/ C0 ]& q {
$result['message'] = '上传失败';
- s- L- g( G3 _5 i/ n. K5 K1 c }
/ l, a, S1 \; h- E }else{
4 |$ H- Z9 e: F* A U; P $result['boolen'] = 0;) e2 ^1 W; K5 N Z
$result['message'] = '上传失败';) o1 C; V6 Z: I$ r
}& o: G6 K' ~0 S& y- f I
return $result;" d9 a6 f. u! O/ V
}
: F3 ]0 @# _6 _9 q/ `% G d0 G9 \' c3 J/ t+ q! T! G+ h
( L$ X2 ^" M2 M8 o7 h- ?, |
|