微博上传图片时只在前端进行验证, 服务器端没有进行安全过滤。
1 p; J* U" _! B" j
. g' C: [! G; a/ C/ Q: Y1 w
4 h4 u/ S% Y1 v6 N\api\StatusesApi.class.php
/ k6 |1 }7 O; Y9 y
% ^1 g! _, x* w( s% o6 m/ Gfunction uploadpic(){! P0 _: Y1 G. G/ R* l0 e
if( $_FILES['pic'] ){5 x8 [ C4 M0 q' ?9 n+ d/ W
//执行上传操作
2 k$ q) H2 I6 j8 U/ L# W $savePath = $this->_getSaveTempPath();
: ^4 A: @2 v0 m6 ]/ ~$ B5 ?$ ~0 g $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);8 ~% X3 v y5 I! `# {& w' K) V x
if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))6 t8 ?. w) C: m0 }+ ~' z, D4 p0 w
{
1 U$ {: O& C! J& Y/ | $result['boolen'] = 1;3 w! k3 O. x7 g
$result['type_data'] = 'temp/'.$filename;
o0 ?: f! M- M M8 L $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;' |. Q9 E" {$ J5 ?* X; }
} else {9 y( G/ ?+ O8 E$ a6 v
$result['boolen'] = 0;& Q5 f( A+ a3 m4 o
$result['message'] = '上传失败';
1 x4 v# ^3 s6 Q% \ }2 p2 l% \- ]" S! R9 c
}else{2 g ^/ E) S) N {% N
$result['boolen'] = 0;
% a# V" c0 C- L6 H$ l $result['message'] = '上传失败';0 l! n6 D$ n3 p) d3 J3 R9 F
}
2 t; j, z u) K! D) areturn $result;
, t% u' j& B7 t; d/ s( Z4 I } D& ?, G" t6 o6 L4 V6 e/ Q7 H
unloadpic()方法没有对文件类型进行验证
' w* I1 c+ T4 n! b9 {5 ]
6 s; ^' K* K% V, r' J0 K可以构建表单, 选择任意文件, 提交到
- J% i) {' r5 u+ Z; Y l5 e( m/index.php?app=w3g&mod=Index&act=doPost' _, F1 A% i) i% C: O( \$ H, }- S
/ m! |% |" o1 J8 r在新提交的微博上可以找到上传的文件地址(去掉small_、middle_ 前缀)" d7 u5 x! m) \( U$ q$ u
9 R$ F% q6 H5 q' n" Q
8 V+ k, O; {% x, j6 {
在登录thinksns官方微博后,
( Y/ E: z7 T) Q) N1 I- f构建以下表单:- ]& Y) L" X5 a9 i( e% d& }
. G+ F) j" U5 C$ B7 b6 A8 Q% ~<form action="http://t.thinksns.com/index.php?app=w3g&mod=Index&act=doPost" method="post" enctype="multipart/form-data" />" B: B; _$ H4 O
<textarea name="content">test</textarea>! \$ J7 A; [" y+ N4 ?9 k
file: <input id="file" type="file" name="pic" />1 C/ P( m! @/ O1 m5 {
<input type="submit" value="Post" />
( |, c: ^3 s. F) V</form>
$ C8 E4 D6 z3 A, H去掉缩略图的前缀(small_ )
0 {- w. r( O" S1 |+ e修复方案:; }( m m+ \# b5 w [* g1 i' P6 S
( ^7 z& T3 Y& L. k
: J& W; h+ [: k* Y
\api\StatusesApi.class.php( S! p& r% Y. w/ n
: b2 K2 Y" h0 [3 n! m2 A7 Mfunction uploadpic(){
( ^& t+ i7 z ?6 _ /**) V4 [. w2 g) ^$ w0 ~( O- C
* 20121018 @yelo
! e- O; N0 M4 a- r' m1 P * 增加上传类型验证/ J& v. D' a- C
*/
# T4 Z; D" L) L5 J/ \ $pathinfo = pathinfo($_FILES['pic']['name']);
4 u( o( J3 ]% u; t% C $ext = $pathinfo['extension'];9 T' _& s! A2 Z* j! a7 r
$allowExts = array('jpg', 'png', 'gif', 'jpeg');9 ~3 W5 s: D5 U$ s
7 `" u7 ?1 N4 f+ M $uploadCondition = $_FILES['pic'] && in_array(strtolower($ext),$allowExts,true);
- I1 M3 [. x- J5 ` ' a# U2 U! `' ? i* S6 O/ g
if( $uploadCondition ){: s' i3 \4 s8 ]' d/ h3 J. q
//执行上传操作. b* H8 t+ |* g0 K! a2 j ~
$savePath = $this->_getSaveTempPath();: E- ?+ K: D; M4 L5 o7 c2 }3 O
$filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);' b; ?3 v& l. {# ~+ d9 R
if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))" m8 S6 j9 W- F, x# V9 y1 o
{/ X: V9 R4 {7 N" o
$result['boolen'] = 1;1 K) ^8 w; R: e% |+ D8 O) z8 _5 o
$result['type_data'] = 'temp/'.$filename;
$ C( ~" e* }1 g" w% N' s* ^ $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;6 i; f5 e4 k* w: C
} else {* W* i4 q `1 a/ w
$result['boolen'] = 0; G; `! Y! n( _" Z7 i* C4 V' J
$result['message'] = '上传失败';
4 C3 S+ q/ l: m0 p }
: \4 T5 o: U! B% R& M" O4 o }else{3 t7 ?) l4 ]- m, F8 K2 N m
$result['boolen'] = 0;, u& ?* i6 w- F) \# I% E8 p
$result['message'] = '上传失败';) M% W/ _, E/ i& b' a
}
# L j; U- J# N6 e% v9 Qreturn $result;" H" `" g; b. f# N! T* t4 @: p
}' ^* `4 X' ]1 G, |* M( Y: D
! S9 ^. f0 d7 r/ Z8 Z- @' P* b" M0 M0 e2 G0 _3 t9 d5 K; V, |
|