微博上传图片时只在前端进行验证, 服务器端没有进行安全过滤。
2 L9 n0 _ ]7 L. }" z; j4 z: Y/ f0 l- k4 K
C! B( ]' U; e$ z5 h0 J
\api\StatusesApi.class.php$ K: `4 U4 Q8 Y
$ c0 ^8 A6 q2 ~4 h# I0 @
function uploadpic(){
$ F# C9 g, r3 _" W4 b* T; D0 [6 ^ if( $_FILES['pic'] ){ R! V6 A9 l- q% `6 H
//执行上传操作
& V _7 g9 d- o- f7 ]( u* j: i $savePath = $this->_getSaveTempPath();; w& U- [& a) G. e. e
$filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
' O% s5 S; S+ X/ Z6 q5 k6 ` } if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))
: N1 r% O1 P- J {
4 j' ~$ B y& I& n ? $result['boolen'] = 1;
: T- h" {5 ~" s' K: y! D: H- E& j $result['type_data'] = 'temp/'.$filename;% g! ^( f/ n F! j5 D% f% Z$ |
$result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;% K! w, E/ E1 r7 ?# X! L/ t
} else {
- i8 M1 D' _8 q( f7 \ $result['boolen'] = 0;8 q, `# U3 i" U2 @' B; D
$result['message'] = '上传失败';
- p" d0 p# m q }
5 F) z9 h5 F B8 ^/ ` }else{5 h8 ?# q! N7 w% y. d
$result['boolen'] = 0;
; j* e' c, [9 A$ h9 r% ?5 o1 Z $result['message'] = '上传失败';! U/ P+ k5 K8 I
}; C. ^% \1 V$ q# V: O3 n
return $result;
2 M# r3 \! {8 X5 D/ I }
W- \0 a* l" |5 ^! C: lunloadpic()方法没有对文件类型进行验证1 h3 L# z3 H" a w
. V1 w) ]3 C- f. p( n可以构建表单, 选择任意文件, 提交到
0 W0 N8 n( j! M7 v7 `+ j# x/index.php?app=w3g&mod=Index&act=doPost
- B1 @8 m1 l) U+ l. ?. ?
1 P R3 J+ a2 J1 O5 M在新提交的微博上可以找到上传的文件地址(去掉small_、middle_ 前缀)9 G+ T6 h' M, M0 X7 k7 P, T4 ^
' S j+ d+ T$ T& \" ~ s8 f
: ~8 z/ t: F$ M/ a9 J' ?在登录thinksns官方微博后,
2 `! A( R: ~6 b- l构建以下表单:8 r5 w1 j: j" G
O1 ?( k# d# L7 M' D# {<form action="http://t.thinksns.com/index.php?app=w3g&mod=Index&act=doPost" method="post" enctype="multipart/form-data" />1 A$ Y8 y$ v( M) v" b$ i
<textarea name="content">test</textarea>
) h. v7 j1 I; |% h! @" u- Dfile: <input id="file" type="file" name="pic" />5 x! c" C( \ V# ]! q
<input type="submit" value="Post" />- s& G& I- J) x f' ]9 W; v
</form>$ K( V! v3 e2 T c" H
去掉缩略图的前缀(small_ )
( X9 {: L6 \+ I/ r' _修复方案:- F- T _4 D7 k0 J$ m* A
! e( F2 u2 n% M6 n! f0 i3 ^3 D* ]4 V0 K) ]$ p
\api\StatusesApi.class.php
* S. v' F2 t' b6 E: U: G) y) E! r6 A
+ v1 m, t U' S# Z& }" r' `function uploadpic(){
; _- ]# w9 Q1 i; \# S /**
( J# K! L% v& y+ j; [& i+ c5 J5 c6 E * 20121018 @yelo j! ]/ z: c) a: f* [6 u" E
* 增加上传类型验证 o& c# r6 a, i5 i; M
*/
. a; G' _3 G3 _6 P. R1 o $pathinfo = pathinfo($_FILES['pic']['name']);) {8 Z' E+ C5 ^7 |3 h: Z* f5 V
$ext = $pathinfo['extension'];
2 J' a4 n5 C. D $allowExts = array('jpg', 'png', 'gif', 'jpeg');
% `9 K8 r/ V0 n6 M, k/ O# o / s; V# D4 i, a2 ^6 H2 g
$uploadCondition = $_FILES['pic'] && in_array(strtolower($ext),$allowExts,true);
4 y. Y+ c4 K( }. J: Y2 D3 Q ! @4 l9 L3 X! ^
if( $uploadCondition ){
+ Q. H1 w( P! K. h //执行上传操作
2 l& Y: x `' S& @2 `7 k2 _ $savePath = $this->_getSaveTempPath();
7 n; ~* L) T1 f $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);& g; x2 y, j- d" [0 Y j% Y# T6 [' T
if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))# C8 V$ Y1 W* B( h6 p w
{
3 m2 m ~9 o3 v6 z $result['boolen'] = 1;
! g5 u/ u3 ]4 m# A' M( o3 K- H $result['type_data'] = 'temp/'.$filename;
- w6 M3 K' @& V$ Q |2 s! d$ H $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;+ c# v- q% m+ I" I% i/ d! d0 w
} else {8 @2 i: V7 d6 q7 ]- t
$result['boolen'] = 0;" }/ W5 c+ W7 c! m {5 ~$ S p
$result['message'] = '上传失败';
7 p% S* J, `1 H$ Y1 S; U }- ~9 j, _" W4 y1 F5 ? }' N
}else{ Y3 a& `$ E: H4 G/ ^/ k( \2 ~5 Q
$result['boolen'] = 0;5 }6 b6 v: M/ N. l/ y
$result['message'] = '上传失败';
8 l+ T& W: h% b: R. {) | }
/ @! P: U+ n9 {4 {+ L; ?: P, kreturn $result;
; \* h5 c- @' D3 L! H* ]! p }
7 ~$ u5 N3 ]3 k/ F
' S1 H4 S* i" o. \+ y$ ]1 L( @. D. ?" H8 q. M( O9 z
|