微博上传图片时只在前端进行验证, 服务器端没有进行安全过滤。
* @% A! X; p, e. ^ d$ C
3 H6 N. F" R6 a
. B2 x! e( M% [) s+ d7 ]\api\StatusesApi.class.php
/ u& B1 v& \8 O: {4 F( C ( |( L4 L. H: }" r
function uploadpic(){ G4 @( p0 y2 y! A6 l0 g; x2 l x
if( $_FILES['pic'] ){! Q- ?8 T+ v6 Q/ P' Y0 P
//执行上传操作
. L( V0 B8 l2 ]; [2 f! y" v $savePath = $this->_getSaveTempPath();
( {0 j( g% `1 P8 K. T; K% \6 }% Y $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
% M" V3 c# f* S6 e1 H if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))# J+ X- O- e# k
{
% H9 M# U0 G& O, I6 K5 u3 ^) h $result['boolen'] = 1;
) ]4 N9 q3 u" m4 }7 Y $result['type_data'] = 'temp/'.$filename;
R/ t" L0 H% q6 L $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;7 a4 G7 Q1 t! [: ~5 i3 w
} else {( O0 T: Z( B( q9 { [- h |
$result['boolen'] = 0;" M' w, w2 o7 ?+ `- @5 ? B
$result['message'] = '上传失败';; ]- R" r" e3 u4 a* C* f/ C
}* A7 H' g3 ]" o) h
}else{
. c; D0 @: j3 R$ \5 Q! b $result['boolen'] = 0;* J3 l2 ?( Q* N$ n# h# M
$result['message'] = '上传失败';4 C: R1 T; z5 J0 _+ r
}) P9 O3 j7 B# Y) H k
return $result;
1 p) i5 |) S2 D8 y- l2 A* O2 q }3 V5 \) z' S2 c6 e
unloadpic()方法没有对文件类型进行验证
o' m+ Z4 G, n3 }; O, B/ J6 ?0 F- v 8 B* t& s5 |8 r |) ]% o7 _
可以构建表单, 选择任意文件, 提交到$ ]1 b& J' y, }/ a( q5 P
/index.php?app=w3g&mod=Index&act=doPost
/ H3 `, s8 T8 i! \* Z 8 [: A4 L. P& k) A( ~2 c; ?
在新提交的微博上可以找到上传的文件地址(去掉small_、middle_ 前缀)
+ x5 y' |6 I/ Y& s9 x0 l o/ v+ X
1 a- J: t- v( ]3 h6 q) X& |0 p$ U+ O: x# \: a: g
在登录thinksns官方微博后,3 X/ ^0 Z/ Y/ s& e6 {6 B
构建以下表单:
( D+ O4 R$ Y1 K# n " P5 s" R" }2 G: P# B$ o. A5 h
<form action="http://t.thinksns.com/index.php?app=w3g&mod=Index&act=doPost" method="post" enctype="multipart/form-data" />
2 x7 b% m, L; v0 {) v; A( u9 T6 t<textarea name="content">test</textarea>
$ s: u I; m2 L6 N9 Ffile: <input id="file" type="file" name="pic" />8 g0 o: g: @. z( _! Q$ c. M1 F
<input type="submit" value="Post" />6 ^9 m1 }/ X9 q. x' e* n& R/ j
</form>
5 m+ F6 H( s+ B- _去掉缩略图的前缀(small_ )- k; @) U% k: W( x
修复方案:
7 B' Q; R2 q; X2 \1 P
6 M. T' t* U2 T% Q/ u0 \( o
6 T6 F: Y. I2 Z5 A\api\StatusesApi.class.php
7 e! Z: A( @+ R
( C* q* W# ?, ~/ [0 z+ J9 l- u0 |function uploadpic(){
) D Z- m# x* n3 Q; L /**
3 A! C- y% C" U5 B' I) o, c- ?( s4 D * 20121018 @yelo
" O* |% d# X0 m7 R8 c * 增加上传类型验证 s; W, O0 N6 u3 P/ Z" ^
*/4 N7 m7 t+ l2 p5 S, Z0 ^5 O3 Y/ a3 _8 p
$pathinfo = pathinfo($_FILES['pic']['name']);7 U4 [0 S C& y; U. @# g6 }
$ext = $pathinfo['extension'];- c0 q, a# a L1 U/ P! J% O
$allowExts = array('jpg', 'png', 'gif', 'jpeg'); d! r1 `7 C W/ ^
1 m+ S, e6 [; a$ `# w $uploadCondition = $_FILES['pic'] && in_array(strtolower($ext),$allowExts,true);9 |1 m. X1 }2 ]1 h1 G' d$ G8 _
z- e1 Z5 Q$ Y l' V, |: \ if( $uploadCondition ){
. y: [( h. s+ D$ L% f$ G/ Z //执行上传操作0 F2 T" L$ E, ]& _
$savePath = $this->_getSaveTempPath();/ m, ^ K3 r- d( O: c, e" q
$filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);' n/ ?9 ]) v8 B- U/ S5 C+ H0 w. ~1 ~
if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))
, R1 ]( ^2 t% J: H {
! X U" N2 `# Q $result['boolen'] = 1;
! b' e, z. t0 @! t( q$ c $result['type_data'] = 'temp/'.$filename;
) X3 l$ C) F; l _ $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;3 m* }; y- e h4 M0 @6 ^) H0 p
} else {
9 }* a1 w- w- S. A6 c; j $result['boolen'] = 0;* ]& |* w1 w# u6 W) X1 c
$result['message'] = '上传失败';
6 |( V- U3 ]- \ }
9 E" t, V# V; X9 X, m, ]7 g1 | }else{. }$ G$ [# H* V; \7 \7 ]
$result['boolen'] = 0;( r, l4 x- f7 `. N
$result['message'] = '上传失败';
/ d2 e/ G+ C) y; d% X }
9 K# m9 N# _( I6 {. Kreturn $result;
) s. `3 z4 D& X2 \. T }
8 b' E, r" }( M/ ?' B; g! Q3 w/ C0 {6 P3 i7 t, ~. J
! a4 u [( t. |- e R% S
|