微博上传图片时只在前端进行验证, 服务器端没有进行安全过滤。
( Z* }/ e& M9 ^* s% n
* B7 d1 T X* z7 [5 {) `) X( o
2 P9 M% p# u! d) H5 ]\api\StatusesApi.class.php
" e% U6 `" h2 k' ^0 V
7 l% ` f) U) [, b. p1 P, q9 ifunction uploadpic(){
/ G" ?) X+ ]; n7 [ if( $_FILES['pic'] ){
2 F- a% [7 c4 J$ u5 R5 \ //执行上传操作! z, j+ K# j9 _: N7 z5 w
$savePath = $this->_getSaveTempPath();" H* V) t/ N7 l* }/ A! o
$filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
' w3 x1 X" A; c- u# E5 K# D if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename)), D6 {" l! A" y7 L- _
{
+ [1 r- `$ ]5 i# Y2 f8 i0 ~; }+ j% I $result['boolen'] = 1;
B9 `$ x( n$ |% z) ~ $result['type_data'] = 'temp/'.$filename;
. e2 ]& V( O1 ~/ } ? $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;
: W' a! T1 p, Z7 ~7 n& V } else {& Q& C! _2 K1 L# m
$result['boolen'] = 0;
9 |7 i6 {5 \. {3 _5 o $result['message'] = '上传失败';
1 H6 E( C" s! v8 U8 I }
9 A9 x& I, Q3 ? }else{" [* O( {0 D$ c( s. a
$result['boolen'] = 0;/ s$ e3 t8 P- L4 c! e7 h* T1 _" |" M
$result['message'] = '上传失败';1 Q8 C0 E8 M8 i
}
2 b1 i9 j6 b5 m+ Hreturn $result; n6 c* v: \& e
}
. r2 ]: N) P) j6 _1 vunloadpic()方法没有对文件类型进行验证6 n" e; v3 o0 R! v- Y1 K
6 p& _; `4 D7 b可以构建表单, 选择任意文件, 提交到
+ b5 `% A8 {6 b" x# r; B% C/index.php?app=w3g&mod=Index&act=doPost
' r, ~! f2 c- P+ J- t A) K ! q7 c- `; K+ @4 m Y: y5 w+ Y
在新提交的微博上可以找到上传的文件地址(去掉small_、middle_ 前缀)) l# N5 C; h; W( R
( L- m6 I9 V6 N1 s: j' {8 W& ^- y' x, M2 ?: o: J) T
在登录thinksns官方微博后,
% x* g% {3 z0 I* x; H构建以下表单:
, h4 H% g, J4 J3 {0 \
( }, Q/ T4 Q7 e: a7 \4 `3 a" F<form action="http://t.thinksns.com/index.php?app=w3g&mod=Index&act=doPost" method="post" enctype="multipart/form-data" />
/ B- s8 W3 V2 T4 B; [. P7 N5 p<textarea name="content">test</textarea>3 ^0 m _6 M. n# b: `/ G+ c/ f: e
file: <input id="file" type="file" name="pic" />6 K' v# B1 b5 Z9 V. h/ b5 W) c
<input type="submit" value="Post" />9 @" T8 p7 w# s. t) v8 j
</form># }/ R1 O2 \3 Y7 j5 }
去掉缩略图的前缀(small_ )( j% L C2 [" \; M' L7 H5 h
修复方案:8 q, q+ @( p+ I7 L
3 n$ z1 y+ b2 A3 a+ P9 U a5 E: n9 c6 f$ R
\api\StatusesApi.class.php
! T; Q, w. g* a+ W" ~) e( U* _
6 e8 d e+ J3 Q9 q0 y$ X9 tfunction uploadpic(){
0 e- j% U$ M* r( C$ @ /**
/ C. x/ M$ A) C7 x2 c * 20121018 @yelo4 d! Q' e7 [ E6 u
* 增加上传类型验证6 i3 ~6 d+ ^: s% E6 \- Z! d2 D: e0 {/ z
*/
8 S$ {- l! u [+ @+ W" L6 I/ @ $pathinfo = pathinfo($_FILES['pic']['name']);
1 ?. D7 [- i* X( ~: X- j: Y $ext = $pathinfo['extension'];" ^, \3 Y, h, Q" O
$allowExts = array('jpg', 'png', 'gif', 'jpeg');$ a* Q4 t" P# L! O9 A8 P0 g7 G- X
6 K( ]) \& T( W- q9 a/ b, S
$uploadCondition = $_FILES['pic'] && in_array(strtolower($ext),$allowExts,true);! j; s) r, a+ h
$ p) |" d; S. Q" c* c1 f if( $uploadCondition ){/ U" R$ `) _# H- ^* ^4 w9 i: M% g
//执行上传操作4 N+ p7 a; d2 t# I# A9 [
$savePath = $this->_getSaveTempPath();
( {# e" T: X8 w& C4 f. C0 c' i $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);: B, z4 J, C# V; T, a( P
if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))
) ]7 }' P& U/ ~; G, q/ \) j {
* K$ Y0 x$ q' G4 |8 L' j+ ^6 Y; C $result['boolen'] = 1;9 n7 H( D7 @9 p1 h/ d8 ]8 l4 V, v5 X
$result['type_data'] = 'temp/'.$filename;
1 I1 [5 H1 t0 G8 t$ W, c $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;) e8 j4 c8 R; e1 i1 Q; V, D3 W2 n0 e- N
} else {7 S# C1 O$ `9 B0 p; e
$result['boolen'] = 0;
{% o7 h3 m+ }6 O$ M4 e; L$ S $result['message'] = '上传失败';
+ q- Z& b. {7 d }( _# z' }) O1 i8 Y* }' w' l
}else{) F/ x) [/ K3 Q+ F1 ~
$result['boolen'] = 0;, B; ]' S0 z% B$ d3 H' ^0 v; j
$result['message'] = '上传失败';+ D H8 \/ ~; \& }
}
7 k5 Q3 E# w9 ~9 @/ u4 ~0 ?3 h, Preturn $result;# Z; k# `- S3 s& X
}% z; H1 o& ~- `
# `$ e( j8 A$ r, t9 C
6 l# M& F# s6 ]4 S9 u+ Z, s |