微博上传图片时只在前端进行验证, 服务器端没有进行安全过滤。 P N4 A5 |6 P/ S
S8 {; o+ m- R; a0 _3 M
! D" Q( w, E6 A5 W+ Y$ X\api\StatusesApi.class.php+ ]0 r+ w4 ~' f0 ?( R
0 X3 D0 r1 l+ Z0 \
function uploadpic(){
- Y* w! e! g( f Y if( $_FILES['pic'] ){
, H1 B* d1 h& U1 C //执行上传操作4 N! ^- z' W$ G. y
$savePath = $this->_getSaveTempPath();
, q. H& O; X% C* V3 G; T $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
+ ] I8 ]7 a$ D+ _ if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))
) D7 X# z# G0 C, w% d& x {
; {; } b! L* w $result['boolen'] = 1;! }' B' s- j* A4 p5 j- q
$result['type_data'] = 'temp/'.$filename;
) G5 [+ D( t2 q $result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;1 R9 l, g1 H8 \4 E. t
} else {
: [+ X& U( B, b, I& } $result['boolen'] = 0;
]. Q% E; o; P3 I0 v $result['message'] = '上传失败';/ N* K0 t1 v$ P+ I9 E( O( `
}
2 k( F2 ]. [$ w& l }else{
$ ^$ I- x" Y0 d% t6 s7 u $result['boolen'] = 0;
* _% u' r( F$ @ y/ `- W $result['message'] = '上传失败';2 ~ p. ?# i" {- G
}
+ T4 b, {( p! Z6 p0 S5 Y. [return $result;
# |1 X+ {( f$ {' y2 \3 n) p, L }/ j2 `9 r) |4 X& ^6 }8 Y
unloadpic()方法没有对文件类型进行验证1 P* k8 C; \& h* C
4 w8 f! d0 j8 v/ q
可以构建表单, 选择任意文件, 提交到( | Q' Y! ]: W: }2 T& b0 U! Y
/index.php?app=w3g&mod=Index&act=doPost
* P8 E: h% U& \$ P1 c7 Y 7 s$ m: ~) ?& A" w7 @$ F9 [/ p8 h
在新提交的微博上可以找到上传的文件地址(去掉small_、middle_ 前缀)
: r) z' @9 _6 R, E9 G' ?! c- ]. r9 Z0 A& S* b
# c" l# @3 B$ r$ j
在登录thinksns官方微博后,
0 C0 R' g* u D+ F" v2 F: n构建以下表单:7 [7 q# \& Z1 m$ X
" q4 }0 k9 H% ]: W" q3 q<form action="http://t.thinksns.com/index.php?app=w3g&mod=Index&act=doPost" method="post" enctype="multipart/form-data" />
$ A5 C% P* O' m' G7 S<textarea name="content">test</textarea>8 J% \7 l% T/ S' r
file: <input id="file" type="file" name="pic" />
8 D% c3 K% E/ o1 ]% R9 `, x<input type="submit" value="Post" />& O6 ?$ S' u+ D- k$ G
</form>
" h: y/ W: f: W) c去掉缩略图的前缀(small_ )
% K' S C& i) i+ G' k* B+ q修复方案:+ }% q0 R, g8 R% d
- O d' T; O o5 A- C; p. O8 ~" G M ~
\api\StatusesApi.class.php* w) f, U& F* [
2 D2 Y4 u8 m" y* K' @
function uploadpic(){
' x5 F( y9 ^, c+ F9 Y /**
' O: ]1 o9 q* I * 20121018 @yelo
; g8 \; ^4 m1 ^( ] * 增加上传类型验证
% J* L1 R0 {% W/ b! D1 b4 r9 @6 f */
9 q1 V4 z7 I7 Y7 @; M0 ^ $pathinfo = pathinfo($_FILES['pic']['name']);
8 J4 ?* L' V% E8 M4 r $ext = $pathinfo['extension'];, x3 w: o: Z+ `, m
$allowExts = array('jpg', 'png', 'gif', 'jpeg');
. L+ E5 s7 k3 n$ [* V- W/ _
7 g. m! N; a7 W `4 Z $uploadCondition = $_FILES['pic'] && in_array(strtolower($ext),$allowExts,true);
) F/ s* b/ b! b% U: q$ t ) Z0 ]. O7 I* P. R S2 C
if( $uploadCondition ){+ s/ x: y- E6 P G& H( q: [
//执行上传操作8 _- U7 P, l- `/ `+ c7 V" _
$savePath = $this->_getSaveTempPath();
+ i5 W' T( |# `# \( F$ P8 e $filename = md5( time().'teste' ).'.'.substr($_FILES['pic']['name'],strpos($_FILES['pic']['name'],'.')+1);
7 p' v, [8 [3 q. P5 r if(@copy($_FILES['pic']['tmp_name'], $savePath.'/'.$filename) || @move_uploaded_file($_FILES['pic']['tmp_name'], $savePath.'/'.$filename))
* ^5 j; Y- m1 Z: W' [ {/ h' G# \ r, U9 X* e
$result['boolen'] = 1;! G9 |5 o5 n, s; H9 p: ~+ b
$result['type_data'] = 'temp/'.$filename;% @1 [2 Q1 V0 H5 }2 r
$result['picurl'] = SITE_PATH.'/uploads/temp/'.$filename;
4 C( a6 s. `. W6 X2 ^8 {5 b4 m } else {0 x/ B7 T! n; u/ _% t4 ^
$result['boolen'] = 0;) B8 ~8 H) b9 s% u! N/ U
$result['message'] = '上传失败';
) `' L( I7 w& w0 l/ n }
; c2 G' G8 F& ]4 u }else{
2 J4 J3 T1 ~6 g $result['boolen'] = 0;
, `' I' L. n( I2 Y' K* F8 @- G $result['message'] = '上传失败';0 r! x& p; h- E/ }; w. [6 l2 ~
}6 b8 t' C. \, C2 C! \7 L
return $result;
; Y; e& ~" r; S5 R! d }
- m8 q4 |- p( M7 x, N$ G. a/ D- C! G' }
* a; T) N# d" H, e3 B |