|
|
报告名称:phpcms v9 2013-02-01 会员中心注入漏洞分析报告$ X; }7 W6 U1 f$ l, {0 R
漏洞作者:skysheep
/ a) u; c/ E/ [分析作者:Seay0 C8 M) L$ \% u. e7 Y) a( J& n
博客:http://www.cnseay.com/! p6 R9 ?' x9 }* \0 Z E& J
漏洞分析:; J' B ^; ~ c8 m) |( j5 D: m* h
漏洞存在于 phpcms\modules\member\index.php 文件account_manage_info函数,其功能是更新会员信息。+ y2 E6 Q$ @4 D% s. d1 o2 H
7 h8 U/ Q) ^. R3 f4 o' [0 A' J
# w' ?* r' l0 C. ^( ?
3 b8 g& }+ M0 w/ O. Tpublic function account_manage_info() {
4 D+ `$ A Z. U& N3 a if(isset($_POST['dosubmit'])) { - p; p- r6 t/ T4 ?! W, ?4 A
//更新用户昵称
9 @' D. q, I w& j! z2 C2 o $nickname = isset($_POST['nickname']) && trim($_POST['nickname']) ? trim($_POST['nickname']) : '';
6 i) @/ \" F4 i, C M0 y" i2 s if($nickname) { 8 G9 ` ` X4 a0 _/ j+ s
$this->db->update(array('nickname'=>$nickname), array('userid'=>$this->memberinfo['userid'])); " ]; \" {, {( S& M& s( K
if(!isset($cookietime)) {
3 ~9 v9 r( ~# [/ ]! | $get_cookietime = param::get_cookie('cookietime'); : K7 Y! W3 A4 P& T r8 W0 ]
}
6 z& K2 Q/ a" }6 _& ^ $_cookietime = $cookietime ? intval($cookietime) : ($get_cookietime ? $get_cookietime : 0);
& \, b' n9 a; v9 e* _ $cookietime = $_cookietime ? TIME + $_cookietime : 0; - }8 C) c$ W9 h: f: m/ i
param::set_cookie('_nickname', $nickname, $cookietime);
! j2 d5 [% f) k( w } # Z4 U; U+ g( s
require_once CACHE_MODEL_PATH.'member_input.class.php'; / W* k, V7 b8 B9 T& h! i$ s3 h+ x- t
require_once CACHE_MODEL_PATH.'member_update.class.php'; - _4 M. R' V$ D
$member_input = new member_input($this->memberinfo['modelid']);
. E- s6 V6 U3 I6 h3 W $modelinfo = $member_input->get($_POST['info']); # c5 P3 }$ L. X
$this->db->set_model($this->memberinfo['modelid']); " k% @3 e. \2 I- X3 J& u* |* V( X
$membermodelinfo = $this->db->get_one(array('userid'=>$this->memberinfo['userid']));
6 h4 ?3 C% k' l3 a; Q$ p# M if(!empty($membermodelinfo)) {
. E1 Y: p5 y2 D/ p: W $this->db->update($modelinfo, array('userid'=>$this->memberinfo['userid']));
4 u+ |) v- g# a3 v* T8 s } else {
# z! i" C; D9 f4 Z n $modelinfo['userid'] = $this->memberinfo['userid'];
" W* Z6 a7 Z' M+ r* n/ G $this->db->insert($modelinfo); " b+ h- X' \& t, a: f5 g% \
}
9 ^$ Z5 V0 V/ J6 Y- F. [代码中:$modelinfo = $member_input->get($_POST['info']);取得提交上来的会员模型中的字段,我们跟进member_input类中的get()函数看看,
7 P: i3 f* q) Y, v; z在\caches\caches_model\caches_data\ member_input.class.php 文件中:. u- A z7 O5 {
0 V( t4 ]- y. m/ v: D1 _7 `- n2 C- P6 x, b! e+ k
% n9 V u9 f8 F. ofunction get($data) {
K4 t* C h4 i7 }5 l3 T$ n1 c, J $this->data = $data = trim_script($data);
' w, L4 L: Q' z. c; b9 }1 c, n8 a. P $model_cache = getcache('member_model', 'commons');
: ?# j p! |* d $this->db->table_name = $this->db_pre.$model_cache[$this->modelid]['tablename']; & o5 G) g E3 e, w
$info = array();
4 @" u4 F' F' h8 a" |% R$ _ $debar_filed = array('catid','title','style','thumb','status','islink','description'); 9 T r9 }+ I! i6 U
if(is_array($data)) { 9 r# l I3 V, m+ z2 X8 A! Z3 a0 p
foreach($data as $field=>$value) {
9 i3 f( N w3 e if($data['islink']==1 && !in_array($field,$debar_filed)) continue; + t: {; G+ d: I) p
$name = $this->fields[$field]['name']; : F' @# _( y) ^9 e1 @5 U
$minlength = $this->fields[$field]['minlength']; 5 y: W$ R A( E+ C$ n+ {. V9 l/ M
$maxlength = $this->fields[$field]['maxlength'];
r! J& r B3 |2 D- K $pattern = $this->fields[$field]['pattern'];
! T2 C: h; z' s8 x; H m $errortips = $this->fields[$field]['errortips'];
" Z- S! \( S t2 D, R" \) U if(empty($errortips)) $errortips = "$name 不符合要求!";
9 A) [) e8 r- X8 L# F" W8 @3 _$ R $length = empty($value) ? 0 : strlen($value);
4 M: ?( W( D" _$ F5 @% M, v if($minlength && $length < $minlength && !$isimport) showmessage("$name 不得少于 $minlength 个字符!"); " t R i6 G& i; f
if($maxlength && $length > $maxlength && !$isimport) { / ?% w5 E+ A9 ]0 b0 }0 i: L
showmessage("$name 不得超过 $maxlength 个字符!");
3 Y2 h! u! w m2 e( V# J. k8 C4 z } else {
# t' f! |; e+ }- I4 T str_cut($value, $maxlength);
, U) F+ r+ b) }( k+ u3 x. V! [' Q }
6 R [ t. o0 G' H if($pattern && $length && !preg_match($pattern, $value) && !$isimport) showmessage($errortips);
9 W% {2 {& u5 K9 k$ O if($this->fields[$field]['isunique'] && $this->db->get_one(array($field=>$value),$field) && ROUTE_A != 'edit') showmessage("$name 的值不得重复!"); ( k( x6 \7 V5 e2 F& X
$func = $this->fields[$field]['formtype']; 0 I* r/ H! v- \% _+ C* N
if(method_exists($this, $func)) $value = $this->$func($field, $value);
B1 _# _4 _# U7 `' ]3 [! O $info[$field] = $value; 2 m7 {8 s* `) l! d( j e5 R, b% D' s
} ' U. Z5 I' E# f
} ! l6 m( P/ ]4 v) E3 T
return $info; & v3 c* ?; L- L; e+ N1 Y
}
2 [* i' Q @6 t# W5 m, s. C# @trim_script函数是过滤XSS的,上面get函数一段代码干的事就是取提交上来的字段和值重新赋值到数组,
% a% d' T' b, Q7 t+ D2 m/ n3 Y4 }* G$ ?. F; t6 L1 W, Z
再到phpcms\modules\member\index.php 文件account_manage_info函数. J9 [2 K7 o. e; z: S6 n
过了get()函数之后。# U& h6 w# J% b' k7 ~ r
1 O9 \5 u$ o! N- _ r" C6 P( ~& J6 r1 v
* w' [& }6 p$ Z# o$modelinfo = $member_input->get($_POST['info']);
; [6 R' P. [4 @$ R2 D b/ F $this->db->set_model($this->memberinfo['modelid']); & a0 K2 c, O: \' J; G7 ? `7 V
$membermodelinfo = $this->db->get_one(array('userid'=>$this->memberinfo['userid']));
- ~, e9 m8 `8 K( n" r( \ c6 D if(!empty($membermodelinfo)) {
+ ]# l7 \( F7 I( J7 |3 {" d $this->db->update($modelinfo, array('userid'=>$this->memberinfo['userid'])); 2 i' g ^8 N, c4 {/ W
} else { ( _) \6 p- t) _2 m
直接带入数据库,update函数我们跟进看看
* [2 f3 `" O/ Q2 x" C0 G2 n3 |9 X6 d0 f
. C( Q' [8 |3 w% a6 R. t; Rpublic function update($data, $table, $where = '') {
; ? N4 U% S2 E$ z if($table == '' or $where == '') { $ N2 g! s2 S2 K* I0 t$ ~
return false; 0 A% }6 f! h0 E8 S
}
, D( h6 l/ E0 _) _+ C $where = ' WHERE '.$where; 2 c0 F E( P" ?
$field = ''; 5 r/ ?5 }3 \4 e3 H u
if(is_string($data) && $data != '') { ; O% h4 k7 w+ g/ S4 m
$field = $data;
$ @* |. ^/ O+ K1 n! f) y$ E, \ } elseif (is_array($data) && count($data) > 0) {
4 \% W: T0 A' z, ^ $fields = array();
6 ~/ N, H% {2 }- ?, j) e2 M& T9 J foreach($data as $k=>$v) {
* j |) y! q. X! p) w) _) ] switch (substr($v, 0, 2)) { ' w" u+ Q/ `( m6 H7 w
case '+=': # K! F/ t! V& ^& A
$v = substr($v,2);
8 o# f5 _0 X9 G- O if (is_numeric($v)) {
$ @, c N3 s" D1 Z9 L% Z $fields[] = $this->add_special_char($k).'='.$this->add_special_char($k).'+'.$this->escape_string($v, '', false);
4 x" }, N f* p6 O$ Z } else { . G( x. N- x, T0 W, y
continue; 6 J$ _; \8 T7 P/ r
} 7 k. S0 U. O8 s! o, N3 ~
break; 7 g5 G0 {: Q u2 C- I- R
case '-=': . h4 a3 M. `- e; ^6 z
$v = substr($v,2); 5 S* @& ~, o1 ?! M, p; q$ n
if (is_numeric($v)) {
5 ~9 l$ o9 q6 [' P2 C3 e. y2 s $fields[] = $this->add_special_char($k).'='.$this->add_special_char($k).'-'.$this->escape_string($v, '', false);
1 v" f: j) k c: N } else { 0 G" ]7 Y: M% |* e7 ^
continue;
- y) G3 w+ D" ?% i% o: r } . L" N; d; T0 f9 y2 _, D( v1 u
break; ; u# @; z" Q4 n3 m l" j; w
default: : [+ r% I7 t- X7 B- g
$fields[] = $this->add_special_char($k).'='.$this->escape_string($v);
+ U1 B* [* m9 m* j } 3 x! r5 d# j! i1 E# x( Q
} , n6 T8 S$ ]. @
$field = implode(',', $fields); 9 \) v% b' p9 i8 Y% G- h2 s
} else {
# N( J+ L( R3 t return false; 1 R4 E$ k# e) E
}
" g8 x' j# N+ T ]9 m$ ~1 z7 d $sql = 'UPDATE `'.$this->config['database'].'`.`'.$table.'` SET '.$field.$where;
2 E1 ^: u ?0 G9 D8 h4 s5 M9 L$ { print_r($sql); & |& I. f" r. [
return $this->execute($sql); ! A4 p, w! K) v5 h) H
}
4 M2 W( D! y R" L从头到尾也是没有验证数据库是否存在数组中的字段,然后直接执行SQL语句。也就是说SQL语句中的字段我们可控,导致注入。. u! }. a S4 d- @
7 J8 R0 E6 d9 m- Y
攻击测试: h$ ?4 D$ J. [% | d6 R# m/ N
测试地址http://localhost! }5 j2 v# P+ Y
注册会员seay并登陆。打开firebug工具HTML选项。修改birthday的name值为注入语句
% R" Y7 g2 Z. D6 K! b* L1 i: p
2 d: E$ R3 _- q8 `7 \+ R/ P: L- P 6 d* l j( Z* j+ v8 M; Q
! y7 B5 c, r' F e2 K9 c" o
- P' y. ]: a' f: j' s5 v4 C9 T9 f2 V. B0 m5 M
|
本帖子中包含更多资源
您需要 登录 才可以下载或查看,没有帐号?立即注册
x
|